Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support release configuration for bundling instead of always debug #19603

Open
1 task done
RicardoLans opened this issue Apr 22, 2024 · 1 comment
Open
1 task done

Comments

@RicardoLans
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

When changes happen in assets (js, css, images, etc) we need to execute abp bundle command to get new global.css and global.js files. But to do this every time for each branch when you make a change this is kind of undoable. Also when having multiple PR's with such changes, completing 1 PR results in unnecessary conflicts where the developer needs to merge latest changes into the PR/branch, then execute abp bundle, commit the 2 new files and push them back to the PR.

Our idea was to add the global.js and global.css to gitignore and in our builds always add the abp bundle command.
However this is not working since abp bundle command is always looking in bin/debug directory, but we use release (bin/release) in our builds.

I've checked the source:
File: framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Bundling/BundlerBase.cs
Method: BundleWebAssemblyFiles
First line of code is hardcoded to look in bin/debug.

Describe the solution you'd like

File: framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Bundling/BundlerBase.cs
Method: BundleWebAssemblyFiles

Make the hardcoded bin/debug configurable in order to support release configuration, maybe introduce extra parameter to abp bundle command like abp bundle debug and abp bundle release

Additional context

No response

@maliming maliming added this to the backlog milestone Apr 23, 2024
@RicardoLans
Copy link
Author

Might be resolved when #19968 is completed, because then we don't need to use abp bundle command anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants