Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New consumables scenarios not modifying consumables availability using existing cons_availability_postSwitch #1497

Closed
tdm32 opened this issue Oct 21, 2024 · 1 comment
Assignees

Comments

@tdm32
Copy link
Collaborator

tdm32 commented Oct 21, 2024

The new scenarios for consumables availability work well if set at initialisation, however they are not switching consumables availability correctly when using cons_availability_postSwitch. The initial cons availability remains throughout the full simulation.

Note, existing scenarios all_vital_available, all_medicines_available etc do work with the switch.

This is the working branch for the GF and FCDO scenarios:
https://github.com/UCL/TLOmodel/tree/tara/gf_hss_and_htm_scale_up

In tests/test_consumables.py, there is a new test (test_check_consumables_modified_correctly) which initially sets the consumables availability to 'none', then switches it to scenario6 (all consumables at or above 75th percentile).

Currently, the final assertion fails. This is because after the switch, the consumables availability is still set to 'none'.

Once the consumables scenarios are correctly modifying availability, we expect this test to pass.

PR #1495 (#1495) originally proposed a fix for this which has already been merged into this working branch.

Copy link
Collaborator

pushed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants