Allow declaring and retriveing names associated with draws in the Scenario class
#1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamuri
reviewed
Sep 26, 2024
| @@ -234,6 +234,11 @@ def draw_parameters(self, draw_number, rng): | |||
| """ | |||
| return None | |||
|
|
|||
| def draw_name(self, draw_number) -> str: | |||
There was a problem hiding this comment.
Do draw names need to come from a function i.e. need to be calculated in some interesting way? Instead, you could add a line in the scenario's constructor, such as:
self.draw_names = ['one', 'two', 'three']
or
self.draw_names = [f'draw_{i}' for i in range(0,10)]
?
There was a problem hiding this comment.
They don't need to come from a function, I don't think..... But, I thought it was good to follow the pattern established by draw_parameters(self, draw_number, rng), and also this gives most flexibility.
Most often we define a dictionary of the form:
self._scenarios = {'my_scenario_name': {'ModuleName': {'parameter_name': new_parameter_value}}} and so it's true that we could have instead in the __init__:
self.draw_names = list(self._scenarios.keys()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1451
This line can be added to the
Scenarioclass:and in the analysis script, the draw_names can be retrieved using
Optionally, the existing
extract_parametersfunction can index the parameters being changes by these same draw names.