Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some module parameters do not have a value defined #1421

Open
matt-graham opened this issue Jul 12, 2024 · 0 comments
Open

Some module parameters do not have a value defined #1421

matt-graham opened this issue Jul 12, 2024 · 0 comments
Labels
bug Something isn't working framework

Comments

@matt-graham
Copy link
Collaborator

As noted in #1419, there appear to be a few cases of parameters defined in Module.PARAMETERS (class) attribute that do not appear to have values defined in Module.parameters (instance) attribute after read_parameters method is called (for example init_or_higher_bmi_per_higher_wealth in Demography). We should fix these instance (either by removing parameter definition or specifying a value if appropriate and used elsewhere) as well adding automated tests to catch such instances (see #109).

@matt-graham matt-graham added bug Something isn't working framework labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework
Projects
None yet
Development

No branches or pull requests

1 participant