You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It could have been good if disease modules could be getting resource file path from simulation instead of each defining its own resource file path. This implementation is good as it makes us avoid repetition. In line with this view, the below line of code in simulation could be supplied self.resourcefilepath instead of passing an empty string. Thereafter modules could get the resource file path via the def read_parameters(self, data_folder) method.
Extend the resource file path to disease modules via self.read_parameters()
Make disease modules get the path from simulation in def read_parameters() method(rename data_folder argument to resourcefilepath). Delete redundant paths in each disease module
Resolve all issues arising from resource file paths used outside def read_parameters() method. @matt-graham arleady sent some links of those other places. see the links below
add a test to ensure everything is working as expected
It could have been good if disease modules could be getting resource file path from simulation instead of each defining its own resource file path. This implementation is good as it makes us avoid repetition. In line with this view, the below line of code in simulation could be supplied
self.resourcefilepath
instead of passing an empty string. Thereafter modules could get the resource file path via thedef read_parameters(self, data_folder)
method.TLOmodel/src/tlo/simulation.py
Line 168 in 6494277
Tasks
self.read_parameters()
def read_parameters()
method(rename data_folder argument to resourcefilepath). Delete redundant paths in each disease moduledef read_parameters()
method. @matt-graham arleady sent some links of those other places. see the links belowTLOmodel/src/tlo/methods/scenario_switcher.py
Lines 51 to 54 in 5c5bb25
TLOmodel/src/tlo/methods/hiv_tb_calibration.py
Lines 63 to 64 in 5c5bb25
TLOmodel/src/tlo/methods/hiv_tb_calibration.py
Line 103 in 5c5bb25
The text was updated successfully, but these errors were encountered: