Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendations on GitHub branch protection rules and/or a ruleset recipe to template #417

Closed
matt-graham opened this issue Jun 13, 2024 · 8 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request wontfix This will not be worked on

Comments

@matt-graham
Copy link
Collaborator

matt-graham commented Jun 13, 2024

Is Your Feature Request Related to a Problem? Please Describe

@zmek who attended the Festival of Digital Research and Scholarship workshop asked about recommendations for setting up rulesets to protect main branch with regards to the tutorial we used there.

Describe the Solution You'd Like

I think having some recommendations around a good basic default branch protection rule might be useful (possibly require status checks + pull requests before merging?) and/or creating a ruleset JSON file similar to those in the ruleset-recipes repository Zella linked to that people could import to set up a minimal set of rules.

Describe Alternatives You've Considered

No response

Additional Context

No response

@matt-graham matt-graham added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 13, 2024
@paddyroddy
Copy link
Member

This might be possible via the GitHub CLI? I think we could detect a presence of CLI and a do a lot of extra automated things

@matt-graham
Copy link
Collaborator Author

I had a look yesterday and it doesn't look like its currently possible to add / edit rulesets only view them and similarly doesn't seem to be any relevant options under gh repo edit subcommand.

@paddyroddy
Copy link
Member

I had a look yesterday and it doesn't look like its currently possible to add / edit rulesets only view them and similarly doesn't seem to be any relevant options under gh repo edit subcommand.

That's a shame. If nothing else, we can have JSON files that they could import.

@dstansby
Copy link
Member

I'd say this is out of context for this project, as it's not Python package specific. Perhaps a separate UCL-ARC/github-tooling repo would work for this instaed?

@paddyroddy
Copy link
Member

I'd say this is out of context for this project, as it's not Python package specific. Perhaps a separate UCL-ARC/github-tooling repo would work for this instaed?

I think something I noted from the workshops last week. People who were there knew Python, but weren't very familiar with everything else. So I do actually think there's merit in doing this.

@dstansby
Copy link
Member

👍 agree there's merit, but still think it's outside the scope of this repo.

@dstansby
Copy link
Member

I'm still on the side of this is out of scope (but maybe nice to have in a "git-tooling" or "github-tooling" repo?). Unless anyone disagrees, I'll close this issue in a couple of weeks

@samcunliffe
Copy link
Member

Falls under the scope of a proposed extension to the UCL-ARC/coding-standards.

So I think this can actually be closed immediately. We can reopen if they don't end up adding anything there.

@samcunliffe samcunliffe added the wontfix This will not be worked on label Nov 1, 2024
@samcunliffe samcunliffe closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants