Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful options to prettier #356

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Add useful options to prettier #356

merged 8 commits into from
Apr 17, 2024

Conversation

paddyroddy
Copy link
Member

Have added the flags and just ran over the repo - no manual changes

@paddyroddy paddyroddy self-assigned this Apr 17, 2024
@paddyroddy paddyroddy marked this pull request as ready for review April 17, 2024 10:26
@paddyroddy paddyroddy marked this pull request as draft April 17, 2024 10:27
@paddyroddy paddyroddy marked this pull request as ready for review April 17, 2024 11:00
@paddyroddy paddyroddy requested a review from p-j-smith April 17, 2024 11:01
Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure I like the wrapping of yaml, but it seems to be valid so.... sure?

args: "--verbose --exclude https://forum.image.sc/ --exclude docs/pages --exclude-path '{{cookiecutter.project_slug}}/README.md' -- ."
args:
"--verbose --exclude https://forum.image.sc/ --exclude docs/pages
--exclude-path '{{cookiecutter.project_slug}}/README.md' -- ."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, but I'm surprised that this works. 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought the same, but verified with jless
image

run: bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}"
run:
bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path
}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@@ -29,6 +29,9 @@ repos:
rev: v3.1.0
hooks:
- id: prettier
args:
- --prose-wrap=always
- --quote-props=as-needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature suggestion: Automating wrapping markdown one-sentence-per-line
2 participants