-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useful options to prettier #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not sure I like the wrapping of yaml, but it seems to be valid so.... sure?
args: "--verbose --exclude https://forum.image.sc/ --exclude docs/pages --exclude-path '{{cookiecutter.project_slug}}/README.md' -- ." | ||
args: | ||
"--verbose --exclude https://forum.image.sc/ --exclude docs/pages | ||
--exclude-path '{{cookiecutter.project_slug}}/README.md' -- ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, but I'm surprised that this works. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought the same, but verified with jless
run: bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}" | ||
run: | ||
bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path | ||
}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞
@@ -29,6 +29,9 @@ repos: | |||
rev: v3.1.0 | |||
hooks: | |||
- id: prettier | |||
args: | |||
- --prose-wrap=always | |||
- --quote-props=as-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solves #337
Have added the flags and just ran over the repo - no manual changes