-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 9: Upgrade plan #2219
Open
4 of 5 tasks
Labels
Core
Ocelot Core related or system upgrade (not a public feature)
highest
Highest priority
in progress
Someone is working on the issue. Could be someone on the team or off.
NET9
.NET 9 release
Milestone
Comments
raman-m
added
the
Core
Ocelot Core related or system upgrade (not a public feature)
label
Nov 24, 2024
raman-m
added
the
in progress
Someone is working on the issue. Could be someone on the team or off.
label
Nov 25, 2024
docker buildThis folder contains the Account
RepositoriesOutdated Tags
.NET 8-9 TagsSingle SDK Tags
Double SDKs Tags
Links
|
raman-m
added a commit
that referenced
this issue
Dec 6, 2024
…t frameworks (#2230) * Update Docker * Upgrade all packages and Microsoft artifacts: 1. to the most recent versions available 2. ideally to version 9.0.* * Fix compilation errors * Fix warnings except NU1902: CS0618: 'DiscoveryApplicationBuilderExtensions.UseDiscoveryClient(IApplicationBuilder)' is obsolete: 'This method call is no longer needed, you should remove it.' MSB3270: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "C:\Users\rmaks\.nuget\packages\microsoft.servicefabric.data\7.1.2493\lib\netstandard2.0\Microsoft.ServiceFabric.Data.dll", "AMD64". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. SYSLIB0057: 'X509Certificate2.X509Certificate2(string, string?, X509KeyStorageFlags)' is obsolete: 'Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certificates.' Ignore NU1902: Package 'IdentityServer4' 4.1.2 has a known moderate severity vulnerability * Fix IDE messages * Fix integration tests: The 'Should_be_able_to_use_token_from_ocelot_a_on_ocelot_b' test related to IdentityServer4 requires migration to .NET 9 or removing * Build using the Docker image version 9.24.0 (Linux OS, double SDKs) * Add `BddfyConfig` class to override the default BDDfy report behavior in `Steps` * Disable BatchProcessors * IDE0130: Namespace "Ocelot.AcceptanceTests" does not match folder structure, expected "Ocelot.AcceptanceTests.Properties" Where -> \test\Ocelot.AcceptanceTests\Properties\BddfyConfig.cs L4 * Raynald is refactoring super star! Warning: Unexpected character sequence in array element value. Where: samples\Administration\Issue645.postman_collection.json L135+145 * CA1816: A method that is an implementation of Dispose does not call GC.SuppressFinalize; or a method that is not an implementation of Dispose calls GC.SuppressFinalize; or a method calls GC.SuppressFinalize and passes something other than this (Me in Visual Basic). Where: test\Ocelot.AcceptanceTests\HeaderTests.cs L460 * CA1859: Using concrete types avoids virtual or interface call overhead and enables inlining. Change type of variable 'client' from 'Ocelot.WebSockets.IClientWebSocket' to 'Ocelot.WebSockets.ClientWebSocketProxy' for improved performance Where: test\Ocelot.AcceptanceTests\WebSocketTests.cs L128+180 * CA2211: Static fields that are neither constants nor read-only are not thread-safe. Access to such a field must be carefully controlled and requires advanced programming techniques to synchronize access to the class object. Where: src\Ocelot.Administration\IdentityServerMiddlewareConfigurationProvider.cs L10 * IDE0044: Make field readonly Where: test\Ocelot.AcceptanceTests\Properties\BddfyConfig.cs L21 * IDE0039 Use local function * IDE0059 Avoid unnecessary value assignments in your code, as these likely indicate redundant value computations. If the value computation is not redundant and you intend to retain the assignment, then change the assignment target to a local variable whose name starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names. * IDE1006 Naming rule violation: These words must begin with upper case characters * IDE0079 Remove unnecessary suppression * IDE0330 Use 'System.Threading.Lock' * IDE1006 Naming rule violation: These words must begin with upper case characters: Fix compilation error * Ignore xUnit1004: Test methods should not be skipped
Status: Done 2 of 5 tasks |
raman-m
added a commit
that referenced
this issue
Dec 6, 2024
…t frameworks (#2230) * Update Docker * Upgrade all packages and Microsoft artifacts: 1. to the most recent versions available 2. ideally to version 9.0.* * Fix compilation errors * Fix warnings except NU1902: CS0618: 'DiscoveryApplicationBuilderExtensions.UseDiscoveryClient(IApplicationBuilder)' is obsolete: 'This method call is no longer needed, you should remove it.' MSB3270: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "C:\Users\rmaks\.nuget\packages\microsoft.servicefabric.data\7.1.2493\lib\netstandard2.0\Microsoft.ServiceFabric.Data.dll", "AMD64". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project. SYSLIB0057: 'X509Certificate2.X509Certificate2(string, string?, X509KeyStorageFlags)' is obsolete: 'Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certificates.' Ignore NU1902: Package 'IdentityServer4' 4.1.2 has a known moderate severity vulnerability * Fix IDE messages * Fix integration tests: The 'Should_be_able_to_use_token_from_ocelot_a_on_ocelot_b' test related to IdentityServer4 requires migration to .NET 9 or removing * Build using the Docker image version 9.24.0 (Linux OS, double SDKs) * Add `BddfyConfig` class to override the default BDDfy report behavior in `Steps` * Disable BatchProcessors * IDE0130: Namespace "Ocelot.AcceptanceTests" does not match folder structure, expected "Ocelot.AcceptanceTests.Properties" Where -> \test\Ocelot.AcceptanceTests\Properties\BddfyConfig.cs L4 * Raynald is refactoring super star! Warning: Unexpected character sequence in array element value. Where: samples\Administration\Issue645.postman_collection.json L135+145 * CA1816: A method that is an implementation of Dispose does not call GC.SuppressFinalize; or a method that is not an implementation of Dispose calls GC.SuppressFinalize; or a method calls GC.SuppressFinalize and passes something other than this (Me in Visual Basic). Where: test\Ocelot.AcceptanceTests\HeaderTests.cs L460 * CA1859: Using concrete types avoids virtual or interface call overhead and enables inlining. Change type of variable 'client' from 'Ocelot.WebSockets.IClientWebSocket' to 'Ocelot.WebSockets.ClientWebSocketProxy' for improved performance Where: test\Ocelot.AcceptanceTests\WebSocketTests.cs L128+180 * CA2211: Static fields that are neither constants nor read-only are not thread-safe. Access to such a field must be carefully controlled and requires advanced programming techniques to synchronize access to the class object. Where: src\Ocelot.Administration\IdentityServerMiddlewareConfigurationProvider.cs L10 * IDE0044: Make field readonly Where: test\Ocelot.AcceptanceTests\Properties\BddfyConfig.cs L21 * IDE0039 Use local function * IDE0059 Avoid unnecessary value assignments in your code, as these likely indicate redundant value computations. If the value computation is not redundant and you intend to retain the assignment, then change the assignment target to a local variable whose name starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names. * IDE1006 Naming rule violation: These words must begin with upper case characters * IDE0079 Remove unnecessary suppression * IDE0330 Use 'System.Threading.Lock' * IDE1006 Naming rule violation: These words must begin with upper case characters: Fix compilation error * Ignore xUnit1004: Test methods should not be skipped * Disable Uploading test coverage to https://coveralls.io/github/ThreeMammals/Ocelot
raman-m
added a commit
that referenced
this issue
Dec 12, 2024
* Day 1 * Day 2 * Day 3 * Day 4 * Day 5 * Day 6
Status: Done 3 of 5 tasks |
raman-m
added a commit
that referenced
this issue
Dec 13, 2024
raman-m
added a commit
that referenced
this issue
Dec 13, 2024
Status: Done 4 of 5 tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Core
Ocelot Core related or system upgrade (not a public feature)
highest
Highest priority
in progress
Someone is working on the issue. Could be someone on the team or off.
NET9
.NET 9 release
Tasks
net8.0
,net9.0
target frameworks #2230 → More info in .NET 9: Upgrade plan #2219 (comment)net8.0
,net9.0
target frameworks #2230Regex
objects, removing constructions targeted at old .NET6-7:See PR Best practices for regular expressions versus
Regex
performance review #1348 for follow-up. → Done by #2219 Remove preprocessor directives targeted at old .NET 6 and 7 #2239The text was updated successfully, but these errors were encountered: