Authentication docs could do with a note around .NET 8 changes

[devsbryan]

Docs Update Suggestion

The section in the authentication docs that deals with overriding the mapping of the scp claim no longer applies in .net 8.

• Ocelot Authentication | Auth0 by Okta

The JwtSecurityTokenHandler is no longer the default, and has been replaced by JsonWebTokenHandler

The example in the docs will work in .net 8 by simply replacing the reference to the JwtSecurityTokenHandler.

i.e.

JsonWebTokenHandler.DefaultInboundClaimTypeMap.Remove("scp");
JsonWebTokenHandler.DefaultInboundClaimTypeMap.Add("scp", "scope");

It is perhaps also worth mentioning in the docs that this does not solely apply to using Okta (in my case it also applies to Azure AD)

References:

• Update .NET 8 Docs for Claim Mapping dotnet/AspNetCore.Docs#30935
• https://learn.microsoft.com/en-us/aspnet/core/security/authentication/claims?view=aspnetcore-8.0#claims-namespaces-default-namespaces
• [Breaking change]: JwtBearer, WsFederation, and OpenIdConnect events context properties of type SecurityToken now return a JSonWebToken by default aspnet/Announcements#508

Motivation for New Feature

1. Avoid confusion for anyone attempting to configure Ocelot authentication on .NET 8.
2. Without this change, scopes do not work.

Steps to Reproduce the Problem

n/a

Specifications

n/a

[raman-m]

Hi Bryan!
Welcome to Ocelot world! 🐯

Thanks for reporting this issue and letting us know about these changes in claims mapping!
Will you contribute to update the docs?

Ideally, this issue ticket can be closed by a PR with acceptance tests or develop a sample to merge.
Writing acceptance tests is not easy.
Create a sample is a bit easier.
But I believe simple updating of our docs will be fine too.

Do you have an intention to work on this issue being created by you?

[raman-m]

@devsbryan Could you help us to upgrade docs plz?

[jvanderlei]

@raman-m Can I do it?

I would first update the docs, then develop a sample as you suggested earlier

[raman-m]

@jvanderlei Welcome! You are assigned!

To start development please fork the repository to your account! Currently I don't see Ocelot repo in your account repos.
Also please refer to our Dev Process.

[raman-m]

Please be aware that we have a strict deadline to complete the .NET 9 milestone tasks. How soon can you open a pull request?

[jvanderlei]

I'll send the PR for the documentation today, I'm now just reading the details on the breaking changes.

[raman-m]

@devsbryan Hello, Simon! Are you online?

[raman-m]

Motivation for New Feature

1. Avoid confusion for anyone attempting to configure Ocelot authentication on .NET 8.
2. Without this change, scopes do not work.

@jvanderlei Please note that the issue has been marked with a label. Therefore it would be advisable to write actual unit & acceptance tests to demonstrate the issue. Please include them in the current open PR.
However I have a concern: does Okta Auth provide a sandbox environment for testing and development purposes? How do you utilize Okta?

[jvanderlei]

@raman-m All right. I'm not the most versed dev on acceptance testing, but I'll try my best to deliver it until tomorrow.
And yes, Okta Auth0 provides a development enviroment when you register a new app on them. I'm developing a personal project as a angular SPA and .Net backend

[raman-m]

@jvanderlei wrote:

Please don't rush! Please relax this weekend. You may return to writing tests on Monday.
FYI, we have a dedicated project for tests: Ocelot.AcceptanceTests. Specifically, the tests should be placed in: AuthenticationTests. However, you may create a OktaAuthenticationTests class.

And yes, Okta Auth0 provides a development environment when you register a new app on them. I'm developing a personal project as a angular SPA and .Net backend

Very well. Could you help us register an Ocelot native account for testing from both local and CircleCI environments? We need your instructions on that...

[jvanderlei]

Perfect. And yes, I can. I'll look some more about the registering for CI pipeline, and return to you about this process.