-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on Windows #45
Comments
hi @rashil2000 and thank you for your interest in my projects. re: Bingo - Bingo is built on Bash so I don't know if the command's scripts will run in standard Windows. I suspect it would work fine in WSL. re: Run on Windows ... I would expect, outside of special language tools like python, etc, we would want to support batch files and powershell scripts. I suspect that But for executing batch files, not sure if we would try to execute re: Powershell From my research, you can't just invoke powershell like You need something like There's also considerations like Since you have the source code for Run hand already, maybe you can play around with this a bit and see what seems to function as expected? I'm thinking I'll need to extend Run to allow each
Thanks for taking the time to report an issue and lemme know how your local discovery goes! -TW |
Hi! Here's what I know. (Note that none of the below applies to WSL - both Bash ScriptsSince Addendum No. 1Since Git is written primarily in 3 languages - C, Perl and Bash, anyone who uses Git on Windows already has Bash (and also Perl) installed. Git on Windows uses MSYS2's Bash. So the above method will require no additional setup. Batch ScriptsOf course for proper Windows support it would be good to not rely on external programs such as MSYS2. Batch scripts (with extensions PowerShell ScriptsPowerShell scripts can be run by calling Shebangs and AssociationsWindows does not have the concept of shebangs. Instead, it relies on file extensions and filetype associations. Each file extension has a program associated with it. So the file can be directly run in the terminal (by simply calling it), or by double-clicking it. Windows will pass the filename to the associated program and run it. (This allows for very weird tricks that can't be done in Unix - try running calling the command Addendum No. 2The Unix shells available in MSYS2 (bash, zsh, fish, tcsh etc.) do support shebangs, and unix scripts will run fine, but only under those shells. Addendum No. 3As I mentioned, most files (which have program associations defined for them), can be executed directly. Heck, for some files, you don't even need to specify the file extension, thanks to the PATHEXT environment variable. So batch scripts can be run by just executing their filename, without extension! This is also the reason why Windows users don't have to specify |
Hi!
I wanted to use Bingo. It required Run. So I compiled it. Compilation works, but any Runfile with fail with this error:
The culprit is this line
run/internal/exec/exec.go
Line 68 in 27ff98d
Possible solution: Check if
GOOS == 'windows'
and executeshell
directly, without using /usr/bin/env.The text was updated successfully, but these errors were encountered: