From ff722a18cd67ff8c00132a2bd068ccd99f6d730f Mon Sep 17 00:00:00 2001 From: Kristofer Rye Date: Sat, 10 Apr 2021 09:31:19 -0500 Subject: [PATCH 1/4] fastlane: Change bundle_output and sourcemap_output to match docs Signed-off-by: Kristofer Rye --- fastlane/lib/sourcemaps.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fastlane/lib/sourcemaps.rb b/fastlane/lib/sourcemaps.rb index b0d5c22f15..5c8859a2fc 100644 --- a/fastlane/lib/sourcemaps.rb +++ b/fastlane/lib/sourcemaps.rb @@ -6,14 +6,14 @@ def sourcemap_args when :android platform = 'android' entry_file = 'index.js' - bundle_output = '../android-release.bundle' - sourcemap_output = '../android-release.bundle.map' + bundle_output = 'index.android.bundle' + sourcemap_output = 'index.android.bundle.map' bundle_url = 'index.android.bundle' when :ios platform = 'ios' entry_file = 'index.js' - bundle_output = '../ios-release.bundle' - sourcemap_output = '../ios-release.bundle.map' + bundle_output = 'main.jsbundle' + sourcemap_output = 'main.jsbundle.map' bundle_url = 'main.jsbundle' end From 0e717a21be8db7df1970d8adad7ff4a2cdd039ac Mon Sep 17 00:00:00 2001 From: Kristofer Rye Date: Sat, 10 Apr 2021 09:31:38 -0500 Subject: [PATCH 2/4] fastlane: Remove unused bundle_url sourcemap_args output Signed-off-by: Kristofer Rye --- fastlane/lib/sourcemaps.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/fastlane/lib/sourcemaps.rb b/fastlane/lib/sourcemaps.rb index 5c8859a2fc..d4860fdb16 100644 --- a/fastlane/lib/sourcemaps.rb +++ b/fastlane/lib/sourcemaps.rb @@ -8,13 +8,11 @@ def sourcemap_args entry_file = 'index.js' bundle_output = 'index.android.bundle' sourcemap_output = 'index.android.bundle.map' - bundle_url = 'index.android.bundle' when :ios platform = 'ios' entry_file = 'index.js' bundle_output = 'main.jsbundle' sourcemap_output = 'main.jsbundle.map' - bundle_url = 'main.jsbundle' end { @@ -22,7 +20,6 @@ def sourcemap_args entry_file: entry_file, bundle_output: bundle_output, sourcemap_output: sourcemap_output, - bundle_url: bundle_url, } end From 44fdcd66e26aee8b5082937ac69cd70addb9f03f Mon Sep 17 00:00:00 2001 From: Kristofer Rye Date: Sat, 10 Apr 2021 09:31:54 -0500 Subject: [PATCH 3/4] fastlane: Add bundle_output as well as sourcemap_output Sentry needs both of these files to... actually have the source code? Previously we just sent over the map. Signed-off-by: Kristofer Rye --- fastlane/lib/sourcemaps.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/fastlane/lib/sourcemaps.rb b/fastlane/lib/sourcemaps.rb index d4860fdb16..31adfa42c9 100644 --- a/fastlane/lib/sourcemaps.rb +++ b/fastlane/lib/sourcemaps.rb @@ -63,6 +63,7 @@ def upload_sourcemap_to_sentry "--dist #{current_bundle_code}", "--strip-prefix #{File.expand_path(File.join(__FILE__, '..', '..', '..'))}", '--rewrite', + args[:bundle_output] args[:sourcemap_output] ].join ' ' From b766c3a776b7daa326cf95f1b4f1ce7b0e1fccaf Mon Sep 17 00:00:00 2001 From: Kristofer Rye Date: Sat, 10 Apr 2021 09:38:02 -0500 Subject: [PATCH 4/4] fastlane: Fix a syntax error (missing comma) Signed-off-by: Kristofer Rye --- fastlane/lib/sourcemaps.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fastlane/lib/sourcemaps.rb b/fastlane/lib/sourcemaps.rb index 31adfa42c9..fd6c562757 100644 --- a/fastlane/lib/sourcemaps.rb +++ b/fastlane/lib/sourcemaps.rb @@ -63,7 +63,7 @@ def upload_sourcemap_to_sentry "--dist #{current_bundle_code}", "--strip-prefix #{File.expand_path(File.join(__FILE__, '..', '..', '..'))}", '--rewrite', - args[:bundle_output] + args[:bundle_output], args[:sourcemap_output] ].join ' '