[Feature] Support restoring from a cluster snapshot for shared-data (part 1) #53861
+607
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/common/RestoreSnapshotConfig.java
Show resolved
Hide resolved
xiangguangyxg
force-pushed
the
restore_snapshot_yaml
branch
2 times, most recently
from
cc323ba to
3573838
Compare
xiangguangyxg
force-pushed
the
restore_snapshot_yaml
branch
from
3573838 to
c7b9e88
Compare
…part 1) Signed-off-by: xiangguangyxg <[email protected]>
xiangguangyxg
force-pushed
the
restore_snapshot_yaml
branch
from
c7b9e88 to
7d13b75
Compare
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 109 / 126 (86.51%) file detail
|
srlch
reviewed
Dec 13, 2024
|
|
||
| import java.util.List; | ||
|
|
||
| public class RestoreSnapshotMgr { |
There was a problem hiding this comment.
Should we use RestoreClouldNativeSnapshotMgr?
There was a problem hiding this comment.
Never been named like this before, usually distinguished by namespace.
In addition, this class is common to shared data and shared nothing？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
To support disaster recovery for shared-data
What I'm doing:
Introduce a config file
restore_snapshot.yamlfor FE.Put the image file of a snapshot in
fe/meta/imageand clear thefe/meta/bdb,than use
./bin/start_fe.sh --restore_snapshot --daemonto start to restore from the snapshot.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: