Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] When replica enter decommission, transaction will nerver complete. #49349

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[BugFix] When replica enter decommission, transaction will nerver complete. #49349

wants to merge 13 commits into from
+29 −6

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Aug 2, 2024 •
edited
Loading

Why I'm doing:

  1. Transaction TA writes to a two-replicas tablet and enters the committed state. The tablet's replica are replicaA, replicaB.
  2. replicaA, replicaB generate tasks: PublishVersionTaskA, PublishVersionTaskB. PublishVersionTaskA/PublishVersionTaskB successfully submitted to the beA/beB via RPC.
  3. The machine where beB is located hangs and is not recoverable. Therefore PublishVersionTaskA is finished,PublishVersionTaskB is unfinished.
  4. FE clone replicaC from replicaA, BE report replicaC info. But transactions must rely on replicaA and replicaB, so TA will block on committed.

What I'm doing:

Fixes #52769

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zhangheihei zhangheihei requested a review from a team as a code owner August 2, 2024 15:31
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from cae05c0 to c94cb51 Compare August 2, 2024 16:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from c94cb51 to 4fba366 Compare October 27, 2024 09:27
@zhangheihei
replace func
edaa5e5 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from fc9df16 to edaa5e5 Compare October 27, 2024 10:45
@zhangheihei zhangheihei changed the title [Enhancement] When the server machine is not recovered, make transaction to complete in time. [BugFix] When the server machine is not recovered, make transaction to complete in time. Nov 10, 2024
@zhangheihei
fix bug
5afde94 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from 0ef1c8a to 5afde94 Compare November 10, 2024 17:14
@zhangheihei zhangheihei changed the title [BugFix] When the server machine is not recovered, make transaction to complete in time. [BugFix] When the server machine is not recovered, transaction will nerver complete. Nov 10, 2024
@wyb wyb requested a review from luohaha November 21, 2024 05:15
@zhangheihei
fix bug
d81c304 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from 3ddac65 to d81c304 Compare November 24, 2024 14:24
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from 47f1d8e to 0c6b6ac Compare November 24, 2024 14:33
@zhangheihei
fix bug
2bdb982 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from 0c6b6ac to 2bdb982 Compare November 24, 2024 15:19
@zhangheihei
fix bug
62a40e1 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from c3c5542 to 62a40e1 Compare November 24, 2024 15:46
@zhangheihei zhangheihei changed the title [BugFix] When the server machine is not recovered, transaction will nerver complete. [BugFix] When replica enter decommission, transaction will nerver complete. Nov 24, 2024
@zhangheihei
opt logic
3d4b303 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from a43409e to 3d4b303 Compare December 15, 2024 17:27
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from 00aef55 to 35b6c4d Compare December 15, 2024 17:30
@zhangheihei
remove annotation
843f6c3 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from b00b05f to 843f6c3 Compare December 16, 2024 02:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

luohaha
luohaha previously approved these changes Dec 16, 2024
View reviewed changes
gengjun-git
gengjun-git previously approved these changes Dec 16, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 4 / 7 (57.14%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/TransactionState.java 3 6 50.00% [444, 445, 448]
🔵 com/starrocks/transaction/DatabaseTransactionMgr.java 1 1 100.00% []

@zhangheihei zhangheihei dismissed stale reviews from gengjun-git and luohaha via 2138b9c December 16, 2024 04:45
luohaha
luohaha previously approved these changes Dec 16, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@zhangheihei
bug fix
9aeb453 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the enhancement-transaction branch from 70f677a to 9aeb453 Compare December 16, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@wyb wyb wyb left review comments

@gengjun-git gengjun-git gengjun-git left review comments

@luohaha luohaha luohaha left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@HangyuanLiu HangyuanLiu

@zhangheihei zhangheihei

@nshangyiming nshangyiming

Labels
3.1 3.2 3.3 behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the server machine is not recovered, transaction will nerver complete
6 participants
@zhangheihei @wyb @luohaha @gengjun-git @HangyuanLiu @nshangyiming