Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ExportResourceActionRequest::forAllMatchingResources in Nova 4.0 #141

Closed
3 tasks done
olivervo opened this issue Apr 6, 2022 · 4 comments · Fixed by #144
Closed
3 tasks done

[BUG] ExportResourceActionRequest::forAllMatchingResources in Nova 4.0 #141

olivervo opened this issue Apr 6, 2022 · 4 comments · Fixed by #144
Labels
help wanted Extra attention is needed

Comments

@olivervo
Copy link

olivervo commented Apr 6, 2022

Prerequisites

  • Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
  • Checked that your issue isn't already filed.
  • Checked if no PR was submitted that fixes this problem.

Versions

  • PHP version: 8.1.3
  • Laravel version: 9.6
  • Nova version: 4.0.4
  • Package version: 1.3

Description

Steps to Reproduce

After upgrading to Nova 4.0, the package caused a fatal error which was fixed in 1.3. However, I'm still running into the following error when exporting from an inline action in Nova.

Method Maatwebsite\LaravelNovaExcel\Requests\ExportResourceActionRequest::forAllMatchingResources does not exist. {"userId":1,"exception":"[object] (BadMethodCallException(code: 0): Method Maatwebsite\\LaravelNovaExcel\\Requests\\ExportResourceActionRequest::forAllMatchingResources does not exist. at /vendor/laravel/framework/src/Illuminate/Macroable/Traits/Macroable.php:113)

@patrickbrouwers
Copy link
Member

Best to provide a PR, I don't own a 4.0 license at the moment

@potsky
Copy link

potsky commented Apr 7, 2022

@olivervo I have just replaced for the moment all actions by

ExportAsCsv::make()

https://nova.laravel.com/docs/4.0/resources/#csv-export

@patrickbrouwers
Copy link
Member

@olivervo let me know if the merge of #114 has fixed the issue for you. Tagged as 1.3.1

@mihaileu
Copy link

it works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants