Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingredient handling should deal with multiple things having the same name #214

Open
raacampbell opened this issue Jun 24, 2019 · 0 comments
Labels
bug good beginner issue Good issue for a beginner to tackle

Comments

@raacampbell
Copy link
Collaborator

Both with image stacks (#121) and sparse ingredients (#210) creating a new one will automatically over-write an old one of the same name. I think it's safest if Lasagna always identifies if this is the case and does this:

  • Renames existing item to ITEM_01 from ITEM
  • Renames new one to ITEM_02
  • User tries to add a third ITEM it will be named ITEM
  • A fourth will rename existing ITEM to ITEM_03 and newly loaded ITEM to ITEM_04

This should be in place in the main application's plugin handler. This way add_line_plugin doesn't have to do anything new and we also fix issue #121.

@raacampbell raacampbell added bug good beginner issue Good issue for a beginner to tackle labels Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good beginner issue Good issue for a beginner to tackle
Projects
None yet
Development

No branches or pull requests

1 participant