Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review block_ends in block_analysis.Block #368

Open
jkbhagatio opened this issue Jun 13, 2024 · 0 comments
Open

Review block_ends in block_analysis.Block #368

jkbhagatio opened this issue Jun 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jkbhagatio
Copy link
Member

Right now we're just detecting block ends by seeing if there's a negative diff in pellet_ct values in the block_state file. However, this can fail if there are consecutive blocks with 0 pellets obtained.

Instead, we can either do:

  1. look for 0's in the block_state file, and if there is a large enough gap between consecutive 0's, assume the block ended.

or

  1. use the NaN values in PatchState that occur on block transition.

  2. is probably preferred, since it uses the block_state info directly

@jkbhagatio jkbhagatio added the bug Something isn't working label Jun 13, 2024
@jkbhagatio jkbhagatio added this to the Social Ongoing milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant