Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment state recovery (.tmp files) should be written out more regularly than on workflow stops #487

Open
jkbhagatio opened this issue Jan 31, 2024 · 4 comments
Open

Environment state recovery (.tmp files) should be written out more regularly than on workflow stops #487

jkbhagatio opened this issue Jan 31, 2024 · 4 comments
Assignees
@glopesdev
Labels
bonsai-workflow Requires modifications to the structural acquisition workflow feature New feature or request
Milestone
Acquisition and E...

Comments

@jkbhagatio
Copy link
Member

Currently, tmp files are written out when the workflow is stopped. However, if the process is killed, tmp files are not written out. Therefore tmp files should be written out more regularly, e,g, each Subject write.
@jkbhagatio jkbhagatio added bonsai-workflow Requires modifications to the structural acquisition workflow feature New feature or request labels Jan 31, 2024
@jkbhagatio jkbhagatio added this to the Social0.1 milestone Jan 31, 2024
@jkbhagatio
Copy link
Member Author

We'll mainly look at saved ceph data for state recovery.

@jkbhagatio
Copy link
Member Author

@NeuroThom suggested deleting tmp files on start of workflow as well

@jkbhagatio
Copy link
Member Author

@aspaNeuro suggested tmp dir for tmp files as well

@glopesdev
Copy link
Collaborator

@NeuroThom suggested deleting tmp files on start of workflow as well

This has been resolved in SainsburyWellcomeCentre/aeon_acquisition#208

@aspaNeuro suggested tmp dir for tmp files as well

Do we still need this? If so, we should probably open a new issue to discuss naming in more detail. I would probably leave it for the big refactoring too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glopesdev glopesdev

Labels
bonsai-workflow Requires modifications to the structural acquisition workflow feature New feature or request
Projects
None yet
Milestone
Acquisition and Experiments Big Refactor
Development

No branches or pull requests
2 participants
@glopesdev @jkbhagatio