Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag friendly names will not work as expected if two tags point to the same commit #223

Open
glopesdev opened this issue Sep 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@glopesdev
Copy link
Contributor

In GetDataPath we find the data folder friendly name by looking for the first tag pointing to the current commit hash:

repo.Tags.FirstOrDefault(r => r.Target == repo.Head.Tip) is Tag tag)

This works on the assumption that there is a single tag pointing to that commit hash. If we need to run two different experiments with the exact same commit hash, we will be unable to differentiate the two names, since the code will automatically latch on to only one of them.

@glopesdev glopesdev added the bug Something isn't working label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant