Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupByTime should issue OnCompleted to each group before moving to next chunk #171

Open
glopesdev opened this issue Oct 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@glopesdev
Copy link
Contributor

The current default behavior of GroupByTime when no clock source is provided is to apply a simple GroupBy on the input stream using the computed chunk index as key. This will leave the created groups alive since GroupBy has no way of knowing if other messages with the same chunk index will arrive later.

Ideally, each chunk group should be closed with OnCompleted as soon as a new group is created. We need to think about how to deal with possible resurrections of old groups too, in cases where clock is moved backwards, e.g. when connecting a new synchronizer, etc.

@glopesdev glopesdev added the bug Something isn't working label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant