-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up ROI drawing for users #103
Draft
niksirbi
wants to merge
35
commits into
main
Choose a base branch
from
standard-roi-shapes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added check-manifest pre-commit hook * added no-build-isolation to check-manifest hook
Co-authored-by: Sam Cunliffe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 39.94% 42.01% +2.07%
==========================================
Files 12 13 +1
Lines 691 814 +123
==========================================
+ Hits 276 342 +66
- Misses 415 472 +57
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
This PR implements several improvements in the ROI drawing process:
Major features
Minor tweaks
M23.783,5.092L25.052...
, which is not a particularly useful piece of information. I replaced that by showing the shape's area (in px), which is more useful to know. For example, one can compare the area of an ROI in one video vs other videos, to check if they are consistent in drawing (roughly) the same area.The UI now looks like this:
Still TODO
utils.py
file is now very long and could benefit from some refactoring - i.e. split utilities into separate files, e.g.video_utils.py
,roi_utils.py
. This can be part of refactoring #56