Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to get user feedback on #69

Open
2 tasks
sfmig opened this issue Mar 29, 2023 · 4 comments
Open
2 tasks

Things to get user feedback on #69

sfmig opened this issue Mar 29, 2023 · 4 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@sfmig
Copy link
Collaborator

sfmig commented Mar 29, 2023

Some questions that have come up, that would be nice to get Sanna's feedback on. Feel free to comment or add to the list (tagging everyone in case you want to comment).

  • select all rows per page
    in the metadata and video tables with checkboxes, is it more practical to select all videos per page?

  • thickness of ROIs
    Do we want the user to be able to define a thickness of the ROI boundary?
    This thought was brought to you by this SO answer

    Right now this parameter is user-editable. To set this value the user sets the buffer_around_ROIs_boundaries parameter in the project config. It is not a mandatory parameter, so if it's not defined then no buffer/thickness is set (we can also set 1e-9 as default if none is set).

    Do we want to keep this parameter accessible to the user, or should it be set to a fixed value (e.g. 1e-9) and not editable by the user?

@sfmig sfmig added the question Further information is requested label Mar 29, 2023
@sfmig sfmig added this to the v1 milestone Mar 29, 2023
@sfmig sfmig changed the title Things to ask user feedback on Things to get user feedback on Mar 29, 2023
@adamltyson adamltyson removed their assignment Mar 29, 2023
@niksirbi
Copy link
Member

Question regarding the 2nd point. Does the 1e-9 number have a physical meaning, i.e. is the unit pixels?

@sfmig
Copy link
Collaborator Author

sfmig commented Mar 29, 2023

yes, the input to the shapely.buffer function is a distance that would be in pixels. the meaning would relate to machine precision (see second part of the answer)

@sannatitus
Copy link

I think it would be very valuable to have a button to select all boxes on that page :-) there's a lot of videos!

@sannatitus
Copy link

As for the buffer, I do like it as-is (ability to change it in the input_config.yaml). With the variability in zoo enclosures, including the width of certain metal bars for some species, it's nice to have this feature flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants