Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events tab #72

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add events tab #72

wants to merge 8 commits into from

Conversation

niksirbi
Copy link
Member

Closes #60

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #72 (b150dbb) into main (c46e1bb) will increase coverage by 1.79%.
The diff coverage is 48.64%.

❗ Current head b150dbb differs from pull request most recent head 5940e17. Consider uploading reports for the commit 5940e17 to get more accurate results

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   32.99%   34.78%   +1.79%     
==========================================
  Files          12       13       +1     
  Lines         585      644      +59     
==========================================
+ Hits          193      224      +31     
- Misses        392      420      +28     
Impacted Files Coverage Δ
wazp/callbacks/roi.py 17.17% <0.00%> (+0.31%) ⬆️
wazp/utils.py 22.69% <14.28%> (-0.38%) ⬇️
wazp/callbacks/events.py 32.50% <32.50%> (ø)
wazp/callbacks/home.py 42.85% <40.00%> (-0.48%) ⬇️
wazp/app.py 91.66% <100.00%> (+0.75%) ⬆️
wazp/pages/03_events.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@niksirbi niksirbi added core feature Core functionality and removed core feature Core functionality labels Mar 30, 2023
@niksirbi niksirbi added this to the Minimum Viable Product: v0 milestone Mar 30, 2023
@niksirbi
Copy link
Member Author

This is how the interface looks as of now.
A few remaining points until minimal functionality is achieved:

  • Ensure that the maximum frame index for each video is not exceeded
  • Ensure that no two events occupy the same frame index
  • Add buttons for saving, loading, and deleting (as in the ROI page)

Screenshot from 2023-03-30 17-53-59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify events by inputting frame number
2 participants