Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytorch dependency #72

Open
niksirbi opened this issue Jul 28, 2023 · 2 comments
Open

Add pytorch dependency #72

niksirbi opened this issue Jul 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@niksirbi
Copy link
Member

PR #70 added a model which depends on pytorch, but the corresponding dependency hasn't been added.
We have to add torch to the dependencies, test for it, and update the corresponding installation instructions.

@niksirbi niksirbi added the bug Something isn't working label Jul 28, 2023
@adamltyson
Copy link
Member

It's probably worth having a chat about model dependencies, there are two questions that come to mind:

  1. How are dependencies installed, we we try to do everything with pip, put NeuralPlayground on conda-forge, or have custom installation instructions
  2. Do we separate dependencies, or try to install everything? What if there are models with TF/JAX dependencies?

@niksirbi
Copy link
Member Author

niksirbi commented Aug 2, 2023

For now we've decided to take the following approach:

Don't include torch in the core pip dependencies. Instead, document it in the relevant TEM model and point users to Pytorch installation instructions. Perhaps we could even add some helpful warnings, if someone is trying to use the TEM model without torch installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants