Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Improve line rendering code #283

Open
LogicalError opened this issue Sep 23, 2020 · 2 comments
Open

Improve line rendering code #283

LogicalError opened this issue Sep 23, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@LogicalError
Copy link
Member

We have line rendering code that can render lines with a given thickness and optionally with dashes, but it's imperfect and can definitely be done better more efficiently and have better quality visuals

We should rewrite this and use this everywhere and remove all dependencies on unity line rendering code.
This could then also be used for runtime editing

@LogicalError LogicalError added enhancement New feature or request help wanted Extra attention is needed labels Sep 23, 2020
@babooncodes
Copy link
Contributor

You should probably have an IRenderer that has an implementation for unity, using a commandbuffer that constructs line mesh, similar to https://github.com/realgamessoftware/dear-imgui-unity/blob/master/ImGuiNET.Unity/Renderer/ImGuiRendererMesh.cs

@LogicalError
Copy link
Member Author

@baboongd that would make a lot of sense! The current line rendering code was written before all of this was available in Unity, so it couldn't take advantage of it. But now it definitely makes sense to use Compute buffers to create the line geometry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants