-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign transactions with PKCS#11 #2637
Comments
Here is what you'd need from the user:
Then you can give them a button to generate a private / public key pair. When generating a key pair, you would store the private key label so you can pass it to
|
Code for signing a tx:
|
Code for generating a new key pair:
|
|
Hi,
It is possible to sign an Ethereum transaction with PKCS#11.
Here is a node implementation which I found easy to create public / private key pairs and sign transactions with:
https://github.com/suenchunhui/ethereumjs-tx-pkcs11
If you use this implementation then all sorts of HSM devices can be used instead of a Ledger.
Since Ledger can send its private key to the computer in shards, it is less secure then it was originally advertised as.
Furthermore, HSM devices are not specific to cryptocurrency, so if someone sees you carrying one they won't assume you own any cryptocurrency.
Thus, Rabby's security conscious users would benefit greatly from this feature.
Thanks,
The text was updated successfully, but these errors were encountered: