Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified nonce/gas price is ignored after cancelling sign request popup #2209

Open
Zarigis opened this issue Apr 16, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Zarigis
Copy link

Zarigis commented Apr 16, 2024

Steps to reproduce:

On a hardware wallet account (tested Ledger and Keystone):

  1. Start Send request to self for 0.01 ETH
  2. Click "Send" button
  3. Click "Begin signing process"
  4. Press Escape
  5. Set nonce to 1
  6. Click "Begin signing process"
  7. Check tx on hardware wallet

Expected result:
Requested transaction should have nonce 1 on wallet

Actual Result:
Requested transaction has initial transaction nonce

Notes:
This is the same for any transaction parameters. Once "begin signing process" is clicked then all changes to the transaction are ignored.

@vvvvvv1vvvvvv
Copy link
Member

it's a known issue, you can't change parameters of tx when you click "Begin signing process", all changes will be ignore

@vvvvvv1vvvvvv vvvvvv1vvvvvv added the bug Something isn't working label May 17, 2024
@mqklin
Copy link

mqklin commented Oct 7, 2024

@vvvvvv1vvvvvv is this the same problem as I can't set custom params?

      request.maxFeePerGas = 1_000n;
      request.maxPriorityFeePerGas = 1n;
      request.gas = BigInt(BigNumber(request.gas).times(1.5).toFixed(0));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants