Merge pull request #30 from PhantPHP/email-name-optional

Email optional name
PhantPHP · Mar 19, 2024 · f51cd4e · f51cd4e
2 parents 58afb59 + 797be88
commit f51cd4e
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 3 deletions.
diff --git a/component/Time/Date.php b/component/Time/Date.php
@@ -22,7 +22,7 @@ public function __construct(
 
         $time = is_string($date) ? strtotime($date) : $date;
 
-        if (!is_a($this, DateTime::class)) {
+        if (!is_a($this, DateTime::class) && $time) {
             $time = (new \DateTime())->setTimestamp($time)->setTime(0, 0)->getTimestamp();
         }
 

diff --git a/component/Web/Email.php b/component/Web/Email.php
@@ -25,9 +25,9 @@ public static function make(
         string $messageTxt,
         string $messageHtml,
         string $fromEmailAddress,
-        string $fromName,
+        ?string $fromName,
         string $toEmailAddress,
-        string $toName,
+        ?string $toName,
         ?string $replyToEmailAddress = null,
         ?string $replyToName = null,
         ?EmailAttachmentList $attachmentList = null

diff --git a/test/Web/EmailTest.php b/test/Web/EmailTest.php
@@ -122,4 +122,42 @@ public function testMake(): void
         $this->assertIsObject($email->attachmentList);
         $this->assertInstanceOf(EmailAttachmentList::class, $email->attachmentList);
     }
+
+    public function testMakeBasic(): void
+    {
+        $email = Email::make(
+            'Subject',
+            'Message',
+            '<p>Message</p>',
+            '[email protected]',
+            null,
+            '[email protected]',
+            null
+        );
+
+        $this->assertInstanceOf(Email::class, $email);
+
+        $this->assertIsString($email->subject);
+        $this->assertEquals('Subject', $email->subject);
+
+        $this->assertIsString($email->messageTxt);
+        $this->assertEquals('Message', $email->messageTxt);
+
+        $this->assertIsString($email->messageHtml);
+        $this->assertEquals('<p>Message</p>', $email->messageHtml);
+
+        $this->assertIsObject($email->from);
+        $this->assertInstanceOf(EmailAddressAndName::class, $email->from);
+        $this->assertEquals('[email protected]', (string)$email->from->emailAddress);
+        $this->assertNull($email->from->name);
+
+        $this->assertIsObject($email->to);
+        $this->assertInstanceOf(EmailAddressAndName::class, $email->to);
+        $this->assertEquals('[email protected]', (string)$email->to->emailAddress);
+        $this->assertNull($email->to->name);
+
+        $this->assertNull($email->replyTo);
+
+        $this->assertNull($email->attachmentList);
+    }
 }