Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compression #393

Open
Naamloos opened this issue Nov 15, 2023 · 0 comments
Open

Fix compression #393

Naamloos opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers networking Relates to packet changes and net-code performance Performance related issue priority: medium Moderately important server Relates to the server implementation

Comments

@Naamloos
Copy link
Member

As of right now Obsidian communicates uncompressed with the Minecraft client. This still has to be implemented. See the comment in the Client.cs file.

Obsidian/Obsidian/Client.cs

Line 430 in 4f14c58

// TODO: Compression, .net 6 (see method below)
(TODO comment)

Obsidian/Obsidian/Client.cs

Line 478 in 4f14c58

private void SetCompression()
(SetCompression method)
@Naamloos Naamloos added enhancement New feature or request server Relates to the server implementation performance Performance related issue priority: medium Moderately important networking Relates to packet changes and net-code labels Nov 15, 2023
@Tides Tides moved this to Ready in Obsidian Tracker Jan 21, 2024
@Naamloos Naamloos moved this from Ready to In progress in Obsidian Tracker Jan 21, 2024
@Tides Tides added the good first issue Good for newcomers label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers networking Relates to packet changes and net-code performance Performance related issue priority: medium Moderately important server Relates to the server implementation
Projects
Obsidian Tracker
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Naamloos @Tides