starknet_subscribeTransactionStatus websocket method #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
- Coverage 74.38% 73.86% -0.53%
==========================================
Files 109 110 +1
Lines 11493 11593 +100
==========================================
+ Hits 8549 8563 +14
- Misses 2278 2362 +84
- Partials 666 668 +2 ☔ View full report in Codecov by Sentry. |
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
2 times, most recently
from
c5eb695 to
abfec15
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
dae4ff2 to
bffd2bf
Compare
weiihann
reviewed
Oct 25, 2024
weiihann
reviewed
Oct 25, 2024
| return err | ||
| } | ||
|
|
||
| func (h *Handler) SubscribeTxnStatus(ctx context.Context, txHash felt.Felt, _ *BlockID) (*SubscriptionID, *jsonrpc.Error) { |
There was a problem hiding this comment.
As per the specs, we also need to support historical blocks. Or is it not possible?
There was a problem hiding this comment.
It's not possible. I added a comment explaining this.
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
0ce1ae2 to
b170da1
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
b170da1 to
b617595
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
3 times, most recently
from
cf082b0 to
6b842a7
Compare
pnowosie
force-pushed
the
pnowosie/2209-subscribe-tx-status-ws
branch
from
6b842a7 to
e65a8a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2209
This is based on #2211