enable connection reuse in libcurl #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copperlight
force-pushed
the
connection-reuse
branch
2 times, most recently
from
13c45a9 to
802819e
Compare
Originally, in the `HttpClient::perform()` method, a new `CurlHandle` was created upon every invocation, leading to subsequent calls to `curl_easy_init()` and `curl_easy_cleanup()`, as the variable went in and out of scope while it executed on the `asio::thread_pool`. This meant that there was no opportunity to reuse connections from the underlying connection pool, because it was always cleaned up. By marking the `CurlHandle` with the `thread_local` storage duration, it ensures that the same one remains in use for each thread, thus providing the means to reuse the established connection pool. Fixes Netflix-Skunkworks#51.
copperlight
force-pushed
the
connection-reuse
branch
from
2bff51b to
f51cdb2
Compare
|
To implement connection reuse properly, we need to use the multi interface, which is more involved: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, in the
HttpClient::perform()method, a newCurlHandlewas createdupon every invocation, leading to subsequent calls to
curl_easy_init()andcurl_easy_cleanup(), as the variable went in and out of scope while it executedon the
asio::thread_pool. This meant that there was no opportunity to reuseconnections from the underlying connection pool, because it was always cleaned up.
By marking the
CurlHandlewith thethread_localstorage duration, it ensuresthat the same one remains in use for each thread, thus providing the means to
reuse the established connection pool.
Fixes #51.