Bootstrap testing environment and port over Olympus token tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this! We're finally getting around to reviewing community PRs on this repo, would you mind rebasing this PR with the latest changes on |
0xmichalis
reviewed
Mar 4, 2022
| _trustedForwarder = newForwarder; | ||
| } | ||
|
|
||
| // Can't do this https://ethereum.stackexchange.com/a/79604 |
There was a problem hiding this comment.
The README file has been updated to document the workaround that was used to get this contract originally deployed.
https://github.com/KlimaDAO/klimadao-solidity#build
We either keep the workaround documented, or remove the workaround and this function.
| KlimaToken__factory as OlympusERC20Token__factory, | ||
| // OlympusAuthority__factory | ||
| KlimaToken, | ||
| KlimaToken__factory, | ||
| } from '../../types'; | ||
|
|
||
| describe("OlympusTest", () => { |
There was a problem hiding this comment.
leftover "Olympus"
| chai_1.default.use(chai_as_promised_1.default); | ||
| var expect = chai_1.default.expect; | ||
| var types_1 = require("../../types"); | ||
| describe("OlympusTest", function () { |
There was a problem hiding this comment.
a few more minor "Olympus" references, as well as the Ohm file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported over the token tests from Olympus at commit d02a634c487ed and migrated
hardhat.config.jsto TypeScript in order to execute tests. This should serve as a decent template going forward.Tests can be run with
This is my first PR so any feedback would be helpful and appreciated.