Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparence of invalid fields ? #502

Open
leplatrem opened this issue Mar 28, 2018 · 1 comment
Open

Apparence of invalid fields ? #502

leplatrem opened this issue Mar 28, 2018 · 1 comment
Labels
easy-pick stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. ux

Comments

@leplatrem
Copy link
Contributor

leplatrem commented Mar 28, 2018

In #496 I wanted to add this CSS rule:

input:invalid, input:focus:invalid {
  box-shadow: 0 0 5px 1px red;
}

And it made me realized that we had many places where forms are loaded with invalid values (usually empty strings :))

screenshot from 2018-03-28 09-51-07

What should we do? Should we highlight them in red? Should we show them as red only when focused?

@glasserc
Copy link
Contributor

glasserc commented Apr 6, 2018

Here's what I think would be "most optimal": invalid fields are highlit in red only if they are unfocused and only if they have been "touched" by the user, or the user has tried to "submit" the form (whatever that means for the form).

That seems hard, though. I'd settle for: invalid forms are shown as red once the form has been submitted once.

@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-pick stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. ux
Projects
None yet
Development

No branches or pull requests

3 participants