Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): generate index.ts file to export routes with required types #18

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

mohitxskull
Copy link
Contributor

@mohitxskull mohitxskull commented Nov 4, 2024

Additional

  • Fixed file edit url in docs

@Julien-R44
Copy link
Owner

Cooool thanks!

Maybe we can also update the documentation to remove the instructions that ask you to create a .adonisjs/index.ts file etc : https://tuyau.julr.dev/docs/installation#sharing-the-api-definition

Also, could you please run a pnpm changeset add? And add a quick summary of your changes. See https://github.com/changesets/changesets. We use this for versioning packages and generating changelogs.

Thanks man !!

@mohitxskull
Copy link
Contributor Author

mohitxskull commented Nov 4, 2024

No problem @Julien-R44

Can you please just take a look at tests?

Clicked the wrong button by mistake! 😅

@mohitxskull mohitxskull closed this Nov 4, 2024
@mohitxskull mohitxskull reopened this Nov 4, 2024
@Julien-R44
Copy link
Owner

Looks perfect to me. Thanks a lot!

@Julien-R44 Julien-R44 merged commit b515810 into Julien-R44:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants