Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TrapezoidalLayout #31

Open
mleprovost opened this issue Aug 3, 2020 · 1 comment
Open

Add TrapezoidalLayout #31

mleprovost opened this issue Aug 3, 2020 · 1 comment

Comments

@mleprovost
Copy link

Hello,

I open this issue to discuss the implementation of TrapezoidalLayout, see (https://discourse.julialang.org/t/view-of-lowermatrix-is-not-working-with-ldiv-and-mul/44046/2). This will be helpful to perform ldiv!, mul! on views of triangular matrices for instance.

@dlfivefifty
Copy link
Member

An important component will be to make sure the code works for both TrapezoidalLayout and TriangularLayout, when appropriate. Perhaps a design like this makes sense:

abstract type AbstractTrapezoidalLayout{UPLO,UNIT} <: MemoryLayout end
struct TrapezoidalLayout{UPLO,UNIT} <: AbstractTrapezoidalLayout{UPLO,UNIT} end
struct TriangularLayout{UPLO,UNIT} <: AbstractTrapezoidalLayout{UPLO,UNIT} end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants