Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more custom types #3

Open
giordano opened this issue Jan 20, 2017 · 2 comments
Open

Use more custom types #3

giordano opened this issue Jan 20, 2017 · 2 comments

Comments

@giordano
Copy link
Member

More custom types should be defined and used throughout the package, in order to make it more Julian.

For example, I'd like to use SkyCoords.jl for sky coordinates, but I'd like it first supports entering coordinates with different units, see https://github.com/kbarbary/SkyCoords.jl/issues/6.

@kbarbary
Copy link
Member

Out of curiousity, can you give an example of how SkyCoords types with unit parameters would be used in AstroLib?

@giordano
Copy link
Member Author

For example to completely replace gcirc. I don't really like it as it is now (but it closely follows IDL AstroLib's definition). SkyCoords already has the method to compute the distance between coordinates, but lacks the possibility to input coordinates with different units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants