Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tuples of ranges #198

Open
ParadaCarleton opened this issue Oct 17, 2023 · 1 comment
Open

Allow Tuples of ranges #198

ParadaCarleton opened this issue Oct 17, 2023 · 1 comment

Comments

@ParadaCarleton
Copy link

Declaring ranges in vectors creates type instabilities (which show up as false positives on JET.jl), besides feeling a bit weird and encouraging bad habits (using vectors for a small collection of heterogenous types). I assume it doesn't have much of an effect on performance here (or else it wouldn't be used), but would it make sense to at least allow users to pass tuples instead of vectors?

@ablaom
Copy link
Member

ablaom commented Oct 17, 2023

Thanks for this investigation.

I find it hard to imagine a use-case where the performance improvement of tuples is worth a breaking change. No objection to allowing tuples. PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: priority low / straightforward
Development

No branches or pull requests

2 participants