Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we add benchmarking? #450

Open
JSAbrahams opened this issue Jan 23, 2023 · 1 comment
Open

Can we add benchmarking? #450

JSAbrahams opened this issue Jan 23, 2023 · 1 comment
Labels
tooling Tooling of the project

Comments

@JSAbrahams
Copy link
Owner

Summary of current issue

Currently, we perform no benchmarking.
In general it would be nice to as the project matures include some sort of benchmarking to check to what extent there is regression in performance.

Proposed change

  • Add a benchmarking library to the project, non -intrusive
  • Add a bot perhaps which comments on each PR how performance changed.
    Similar to codecov, so that we can see changes in performance without regressions being blocking.
@JSAbrahams JSAbrahams added the tooling Tooling of the project label Jan 23, 2023
@JSAbrahams
Copy link
Owner Author

Perhaps https://github.com/bheisler/criterion.rs is interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling Tooling of the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JSAbrahams