Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak: Generic Wayland icon is shown in KDE task switcher #1491

Open
mss opened this issue Nov 22, 2024 · 2 comments
Open

Flatpak: Generic Wayland icon is shown in KDE task switcher #1491

mss opened this issue Nov 22, 2024 · 2 comments

Comments

@mss
Copy link

mss commented Nov 22, 2024

Describe the bug
On KDE, when you use Alt+Tab to switch between applications in a Wayland session the generic Wayland icon is shown.

This is probably caused by some metadata missing in the package.json (see below).

To Reproduce
Steps to reproduce the behavior:

  1. Log in to a KDE Plasma 6 Wayland session
  2. Install and start the flatpak
  3. Press and hold Alt+Tab
  4. See generic yellow wayland icon

Expected behavior
The same icon as in the task manager should be displayed.

Screenshots
Can't take a screenshot of the task switcher

Desktop (please complete the following information):

  • OS: KDE Neon
  • Installation package: Flatpak
  • Version: 1.11.5

Additional context

According to https://docs.flatpak.org/en/latest/electron.html#using-correct-desktop-file-name should this be fixed by adding a line

  "desktopName": "com.github.IsmaelMartinez.teams_for_linux.desktop",

to the file package.json. But only for the flatpak builds.

@IsmaelMartinez
Copy link
Owner

Thanks for reporting. Do you know how to do this in flatpak? The manifest we use is in here: https://github.com/flathub/com.github.IsmaelMartinez.teams_for_linux/blob/master/com.github.IsmaelMartinez.teams_for_linux.yml

@mss
Copy link
Author

mss commented Nov 22, 2024

Theoretically yes: I think all what has to happen is that the package.json is amended with that line.

So I guess some jq magic in build-commands should do the trick. But I have no idea where that package.json is found...

Hmmm... that documentation also mentions some patch-desktop-filename helper which should probably called after that desktop-file-edit command. I digged around a bit and I think it should be as simple as calling

patch-desktop-filename ${FLATPAK_DEST}/teams-for-linux/resources/app.asar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants