Github Oauth integration. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muttaqin1 you should add some guide on how to get it working. |
|
@yassineboujrada can you review these changes and see if you can implement it on the frontend? |
Create a Oauth application in github -> developers setting -> Oauth application. Set the callback url = http://localhost:4000/api/v1/auth/github/callback For frontend: <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
<a
href="https://github.com/login/oauth/authorize?client_id=PUT YOUR CLIENT ID HERE&redirect_url=http://localhost:4000/api/v1/auth/github/callback?path=/&scope=user:email"
>Login with github</a
>
</body>
</html> |
|
Thank you, please remind me to add this to contribute.md when we create it. |
You are welcome.I will surely remind you. |
|
done @muttaqin1 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #58