Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially deprecate the package #698

Open
theofidry opened this issue Nov 2, 2022 · 5 comments
Open

Officially deprecate the package #698

theofidry opened this issue Nov 2, 2022 · 5 comments

Comments

@theofidry
Copy link

theofidry commented Nov 2, 2022

I think this package is pretty dead and there is a good replacement https://github.com/thephpleague/oauth2-server-bundle

Since this package is heavily used (over 5k daily installs still – without counting all the forks that just did a patch left and right to add support to a different doctrine or symfony version), I think an official statement and migration docs are in order.

My suggestion would be:

  • Deprecate the package on packagist side proposing composer require league/oauth2-server-bundle as a replacement
  • Work on a migration doc

The first one is unfortunately an admin thing: no one can help but the maintainers themselves IIRC it's @deguif and @pierredup, so sorry for pinging you guys but no one else can do it.

Regarding the migration doc, it still can be a nice external contribution. I am sure a lot of people need to migrate and some might find time to document it. I am happy to help there for reviewing & merging doc PRs if you give me access to.

/cc @chalasr

@pierredup
Copy link
Contributor

pierredup commented Nov 4, 2022

I'm not a maintainer of this package, but I would be happy to take over maintenance and continue development of this package, even if it's just to ensure compatibility with the latest Symfony and PHP versions and to provide a migration path to thephpleague/oauth2-server-bundle

@willdurand
Copy link
Member

Deprecate the package on packagist side proposing composer require league/oauth2-server-bundle as a replacement

I am not too into PHP or Packagist anymore these days.. Maybe @stof still is and IIRC he had access to that package on Packagist. Sorry.

@theofidry
Copy link
Author

Thanks for the reply!

I am not too into PHP or Packagist anymore these days...

I figured, it was more because of perm. issues than anything, sorry I should have checked with stof first!

@blackarcanis
Copy link

Hi everyone,
Any update about this? We are upgrading to SF6.4 and it would be great to know if this package will be maintained or if we need to move to "thephpleague/oauth2-server-bundle" instead. And in that case, having a migration doc would be awesome.

Thank you!

@chalasr
Copy link

chalasr commented Jan 30, 2024

it would be great to know if this package will be maintained or if we need to move to "thephpleague/oauth2-server-bundle" instead

Yes, you need to migrate.

having a migration doc would be awesome.

Sadly, no one took the time to work on such a migration guide yet. One reason is that the path is not quite the same for every project: while the setup is pretty similar and straightforward, there're some differences that would be worth documenting at least.
Pull requests on https://github.com/thephpleague/oauth2-server-bundle are welcome, in case you feel like sharing your migration path while at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants