Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Error on Eslint when running tests #64

Open
bsell93 opened this issue Jun 5, 2017 · 0 comments
Open

Error on Eslint when running tests #64

bsell93 opened this issue Jun 5, 2017 · 0 comments

Comments

@bsell93
Copy link

bsell93 commented Jun 5, 2017

Hey! Is the title implies I am curious if it is possible to error out on test execution (gulp test).

I tried modifying the plugins property in the webpack-test.conf.js file to be like so

plugins: [
        new webpack.LoaderOptionsPlugin({
            options: {
                eslint: {
                    failOnError: true
                }
            },
            debug: true
        })
    ],

But then I get an error that says,

PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  ReferenceError: Can't find variable: angular
  at src/index.html.js:1

So it is erroring out, but not on eslint errors. At least based off of the eslint errors I see when I set failOnError: false.

I believe I am using the latest version of the FountainJS setup.
Webpack: v2.6.1
Karma: v1.7.0
MacOS: 10.12.5

P.S. Great work on this generator! My team/company have been using your generator since way before Fountain! 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant