Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fastly (default for Adobe Commerce on Cloud projects) #205

Open
aadmathijssen opened this issue Jul 12, 2024 · 1 comment

Comments

@aadmathijssen
Copy link
Contributor

Issue Brief

The latest version of the Tweakwise plugin does not support personal merchandising for Adobe commerce on Cloud projects, as these projects use Fastly instead of Varnish.

Environment

  • PHP Version: irrelevant
  • Magento Version: Adobe Commerce hosted on Cloud
  • Tweakwise Version: 7.x
  • Tweakwise Export Version: irrelevant
  • Magento Deploy Mode: irrelevant
  • Third party modules: irrelevant

Details

The \Tweakwise\Magento2Tweakwise\Helper\Cache::isVarnishEnabled method checks whether the value of the system/full_page_cache/caching_application configuration settings is equal to \Magento\PageCache\Model\Config::VARNISH (2).

However, even though Fastly is based on Varnish, it uses a different value: \Fastly\Cdn\Model\Config::FASTLY (42).

@ah-net
Copy link
Collaborator

ah-net commented Aug 22, 2024

@aadmathijssen

Fastly should still work (even though we didn't test it with fastly) because we use the same caching mechanism that magento uses for the header. So we would expect it to still work with fastly.

We will look into this and see if we can add fastly to the check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants