-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag to dismiss item popups on mobile is inconsistent #9903
Comments
I don't think this is recent - it's never really worked for the armory sheet either. The changes to scroll chaining at the very least allow dismissing sheets if they don't have a scroll bar. |
I swear it worked perfectly at one point, but that was maybe before the rewrite to use Framer Motion. |
OK, to summarize some research I did over the weekend:
What's happening as far as I can tell is that the drag begins as expected, but then after dragging for a short distance, Safari fires This only happens when the area being dragged is scrollable. Removing scrolling with One idea I haven't tried yet is to not move the sheet until your finger has moved some set amount, then apply I'll keep plugging away at this occasionally because I really want this interaction to be smooth like it can be in native apps that have full control over gesture recognition. But I'd also love help on this as I'm running out of ideas for a workaround. |
I'm not sure how much this is related to the recent changes to how we prevent scroll chaining, if at all, but I can frequently get into a situation where I can't drag down on the body of the popup to dismiss it. The sheet starts dragging a bit, then cancels. I wonder if the press tips are interfering with it, or if we're missing a pointer capture during the drag.
The text was updated successfully, but these errors were encountered: