Support .NET 9.0 #2215

bijington · 2024-09-18T08:14:49Z

Description of Change

Linked Issues

PR Checklist

Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard
Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Breaking Changes

Major Breaking Changes

.NET 8 no longer supported
Xcode 16.1 Required
Stop automatically assigning Behavior.BindingContext
- .NET MAUI Behaviors do not automatically inherit their parent's BindingContext (a breaking change from Xamarin.Forms)
- Going forward, the .NET MAUI Community Toolkit will follow this implementation of Behaviors
Increase minimum supported OS versions of CommunityToolkit.Maui.MediaElement
- Android 26.0
- iOS 15.0
- MacCatalyst 15.0
Increase minimum supported versions of CommunityToolkit.Maui.Camera to 15.0:
- iOS 15.0
- MacCatalyst 15.0

Minor Breaking Changes

Expander is not trim safe
ValidationBehaviors are not trim safe
CommunityToolkit.Maui.Maps is not trim safe
Remove PopupService.ShowPopop(TViewModel)
- Removes [Obsolete] method
- Use PopupService.ShowPopup<T>() instead
Remove PopupService.ShowPopopAsync(TViewModel, CancellationToken)
- Removes [Obsolete] method
- Use PopupService.ShowPopupAsync<T>() instead
Remove ability to subclass BaseConverter<TFrom, TTo>
- Subclassing from BaseConverter<TFrom, TTo> is not supported
- Support requires documentation and complete unit tests
Remove ability to subclass BaseConverter<TFrom, TTo, TParam>
- Subclassing from BaseConverter<TFrom, TTo, TParam> is not supported
- Support requires documentation and complete unit tests
ValidationFlags.ValidateOnFocusing renamed to ValidationFlags.ValidateOnFocused
ValidationFlags.ValidateOnUnfocusing renamed to ValidationFlags.ValidateOnUnfocused
In CommunityToolkit.Maui.Camera, add linker.xml for net9.0-android to avoid the Linker removing Xamarin.AndroidX.Camera.Core, Xamarin.AndroidX.Camera.Lifecycle, Xamarin.AndroidX.Camera.Video, Xamarin.AndroidX.Camera.View, and Xamarin.AndroidX.Camera.Camera2
public static Task<bool> ShowKeyboardAsync(this ITextInput, CancellationToken) -> public static ValueTask<bool> ShowKeyboardAsync(this ITextInput, CancellationToken)
NuGet package will not support Microsoft.Maui.Controls .NET 10 until .NET 10 GA

Analyzer Benchmarks

.NET 9.0	Mean	Error	StdDev	Median	Gen0	Gen1	Allocated
VerifyNoErrorsWhenUseMauiCommunityToolkit	8.863 ms	0.1748 ms	0.3240 ms	8.724 ms	62.5000	31.2500	1.59 MB
VerifyNoErrorsWhenUseMauiCommunityToolkitHasAdditionalWhitespace	8.695 ms	0.1654 ms	0.4358 ms	8.528 ms	62.5000	31.2500	1.59 MB
VerifyErrorsWhenMissingUseMauiCommunityToolkit	12.071 ms	0.3756 ms	1.0470 ms	11.546 ms	66.6667	-	2.29 MB

.NET 8.0	Mean	Error	StdDev	Median	Gen0	Allocated
VerifyNoErrorsWhenUseMauiCommunityToolkitMediaElement	9.763 ms	0.1928 ms	0.4765 ms	9.633 ms	31.2500	1.46 MB
VerifyNoErrorsWhenUseMauiCommunityToolkitMediaElementHasAdditonalWhitespace	9.565 ms	0.1862 ms	0.4637 ms	9.460 ms	31.2500	1.46 MB
VerifyErrorsWhenMissingUseMauiCommunityToolkitMediaElement	15.495 ms	0.3879 ms	1.0814 ms	15.058 ms	66.6667	2.24 MB

hansmbakker · 2024-09-18T08:48:33Z

The errors are because in https://github.com/CommunityToolkit/Maui/blob/feature/sl-dotnet-nine/azure-pipelines.yml the .NET SDK to install is

set to the LATEST_NET_VERSION variable instead of picking up the version from global.json
set to prevent using prereleases (both in global.json and in azure-pipelines.yml)

See

Maui/azure-pipelines.yml

Lines 73 to 78 in c4169ed

    
           - task: UseDotNet@2 
        
             displayName: 'Install Latest .NET SDK, v$(LATEST_NET_VERSION)' 
        
             inputs: 
        
               packageType: 'sdk' 
        
               version: '$(LATEST_NET_VERSION)' 
        
               includePreviewVersions: false

Note that the UseDotNet@2 task can pick up global.json to read its settings from - I would recommend to define these SDK settings only in global.json and not redefining it in the pipeline as well.

brminnick

Thanks for updating the Analyzer Unit Tests, Shaun! We can just remove the reference to Net80 since we won't be reverting back to .NET 8 after we update the library to .NET 9.

src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharpAnalyzerVerifier`1+Test.cs

src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharpCodeFixVerifier`2+Test.cs

…AnalyzerVerifier`1+Test.cs Co-authored-by: Brandon Minnick <[email protected]>

…CodeFixVerifier`2+Test.cs Co-authored-by: Brandon Minnick <[email protected]>

src/CommunityToolkit.Maui/Behaviors/EventToCommandBehavior.shared.cs

src/CommunityToolkit.Maui/Behaviors/ICommunityToolkitBehavior.shared.cs

src/CommunityToolkit.Maui/Behaviors/Validators/ValidationBehavior.shared.cs

bijington · 2024-09-19T19:25:55Z

The errors are because in https://github.com/CommunityToolkit/Maui/blob/feature/sl-dotnet-nine/azure-pipelines.yml the .NET SDK to install is

set to the LATEST_NET_VERSION variable instead of picking up the version from global.json

set to prevent using prereleases (both in global.json and in azure-pipelines.yml)

See

Maui/azure-pipelines.yml

Lines 73 to 78 in c4169ed

- task: UseDotNet@2

displayName: 'Install Latest .NET SDK, v$(LATEST_NET_VERSION)'

inputs:

packageType: 'sdk'

version: '$(LATEST_NET_VERSION)'

includePreviewVersions: false

Note that the UseDotNet@2 task can pick up global.json to read its settings from - I would recommend to define these SDK settings only in global.json and not redefining it in the pipeline as well.

Thanks for the suggestions. I know we have been discussing about migrating to GitHub actions so I will leave this with limited change for now

…Maui into feature/sl-dotnet-nine

src/CommunityToolkit.Maui/Behaviors/ICommunityToolkitBehavior.shared.cs

src/CommunityToolkit.Maui/Converters/ICommunityToolkitValueConverter.shared.cs

bijington · 2024-12-04T20:25:21Z

Things are looking very positive: dotnet/maui#26303 (comment)

MauiUIui · 2024-12-05T14:19:23Z

Things are looking very positive: dotnet/maui#26303 (comment)

Thanks man. Good news :)
Can we say that a nuget update is a day or so away?

bijington · 2024-12-05T14:27:53Z

Things are looking very positive: dotnet/maui#26303 (comment)

Thanks man. Good news :)

Can we say that a nuget update is a day or so away?

We can say that an update is a day or so away once we receive the official .NET MAUI nuget containing the fix. My test build was against the MAUI nightly feed and I believe we are waiting on SR2 to be released. I am hopeful the release is imminent

MauiUIui · 2024-12-05T19:10:48Z

Things are looking very positive: dotnet/maui#26303 (comment)

Thanks man. Good news :)
Can we say that a nuget update is a day or so away?

We can say that an update is a day or so away once we receive the official .NET MAUI nuget containing the fix. My test build was against the MAUI nightly feed and I believe we are waiting on SR2 to be released. I am hopeful the release is imminent

Thx mate. Appreciate the good work :)

brminnick

We are officially unblocked as Microsoft.Maui.Controls v9.0.21 contains the bug fix for the blocker.

brminnick · 2024-12-12T23:47:23Z

Dang - there is a new error:

ILLink : error IL1012: IL Trimmer has encountered an unexpected error. Please report the issue at https://aka.ms/report-illink [/Users/runner/work/1/s/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj::TargetFramework=net9.0-maccatalyst

https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=112518&view=logs&j=17b0f84d-e186-52d3-858a-533c8ddf3c8c&t=670b1d62-8fe8-5e0d-0040-71e96d237771&l=992

I'll re-add the blocked label while we investigate.

pictos · 2024-12-14T21:37:55Z

During investigation I found that error is caused by a failing MSBuild task, so I reported the issue to the dotnet runtime, hopefully they can fix it and/or provide a guidance

[area-Tools-ILLink]: ILLinker is failing when building a mac-catalyst app dotnet/runtime#110714

Copilot reviewed 431 out of 446 changed files in this pull request and generated no comments.

Files not reviewed (15)

.editorconfig: Language not supported
Directory.Build.props: Language not supported
global.json: Language not supported
samples/CommunityToolkit.Maui.Sample/AppShell.xaml: Language not supported
samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj: Language not supported
samples/CommunityToolkit.Maui.Sample/Pages/Alerts/SnackbarPage.xaml: Language not supported
samples/CommunityToolkit.Maui.Sample/Pages/Behaviors/AnimationBehaviorPage.xaml: Language not supported
samples/CommunityToolkit.Maui.Sample/Pages/Behaviors/CharactersValidationBehaviorPage.xaml: Language not supported
samples/CommunityToolkit.Maui.Sample/Pages/Behaviors/EmailValidationBehaviorPage.xaml: Language not supported
samples/CommunityToolkit.Maui.Sample/App.xaml.cs: Evaluated as low risk
samples/CommunityToolkit.Maui.Sample/Pages/Alerts/AlertsGalleryPage.cs: Evaluated as low risk
samples/CommunityToolkit.Maui.Sample/Pages/Alerts/SnackbarPage.xaml.cs: Evaluated as low risk
samples/CommunityToolkit.Maui.Sample/Pages/Behaviors/AnimationBehaviorPage.xaml.cs: Evaluated as low risk
samples/CommunityToolkit.Maui.Sample/Pages/Base/BaseGalleryPage.cs: Evaluated as low risk
samples/CommunityToolkit.Maui.Sample/Converters/CompareDoubleToColorConverter.cs: Evaluated as low risk

espenrl · 2024-12-15T18:33:42Z

This is the exception from the build log above

https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=112518&view=logs&j=17b0f84d-e186-52d3-858a-533c8ddf3c8c&t=670b1d62-8fe8-5e0d-0040-71e96d237771&l=992

ILLink : error IL1012: IL Trimmer has encountered an unexpected error. Please report the issue at https://aka.ms/report-illink [/Users/runner/work/1/s/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj::TargetFramework=net9.0-maccatalyst]
  Fatal error in IL Linker
  Unhandled exception. System.IndexOutOfRangeException: Index was outside the bounds of the array.
     at System.Collections.Immutable.ImmutableArray`1.get_Item(Int32 index)
     at Mono.Linker.Dataflow.TrimAnalysisMethodCallPattern.Merge(ValueSetLattice`1 lattice, TrimAnalysisMethodCallPattern other)
     at Mono.Linker.Dataflow.TrimAnalysisPatternStore.Add(TrimAnalysisMethodCallPattern pattern)
     at Mono.Linker.Dataflow.ReflectionMethodBodyScanner.HandleCall(MethodBody callingMethodBody, MethodReference calledMethod, Instruction operation, ValueNodeList methodParams)
     at Mono.Linker.Dataflow.MethodBodyScanner.HandleCall(MethodBody callingMethodBody, Instruction operation, Stack`1 currentStack, Dictionary`2 locals, InterproceduralState& interproceduralState, Int32 curBasicBlock)
     at Mono.Linker.Dataflow.MethodBodyScanner.Scan(MethodIL methodIL, InterproceduralState& interproceduralState)
     at Mono.Linker.Dataflow.ReflectionMethodBodyScanner.Scan(MethodIL methodIL, InterproceduralState& interproceduralState)
     at Mono.Linker.Dataflow.MethodBodyScanner.InterproceduralScan(MethodIL startingMethodIL)
     at Mono.Linker.Dataflow.ReflectionMethodBodyScanner.InterproceduralScan(MethodIL methodIL)
     at Mono.Linker.Steps.MarkStep.MarkReflectionLikeDependencies(MethodIL methodIL, Boolean requiresReflectionMethodBodyScanner, MessageOrigin origin)
     at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body, MessageOrigin origin)
     at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method, DependencyInfo& reason)
     at Mono.Linker.Steps.MarkStep.ProcessQueue()
     at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
     at Mono.Linker.Steps.MarkStep.Process()
     at Mono.Linker.Steps.MarkStep.Process(LinkContext context)
     at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
     at Mono.Linker.Pipeline.Process(LinkContext context)
     at Mono.Linker.Driver.Run(ILogger customLogger)
     at Mono.Linker.Driver.Main(String[] args)

And the code can be found here

https://github.com/dotnet/runtime/blob/main/src/tools/illink/src/linker/Linker.Dataflow/TrimAnalysisMethodCallPattern.cs#L45

bijington · 2024-12-15T18:49:13Z

@espenrl please add the detail to the issue opened at dotnet/runtime#110714

Point to the .NET 9.0 release candidate

c4169ed

bijington mentioned this pull request Sep 18, 2024

[BUG] Warning when including a ValueConverter starting in .NET MAUI 9 #2205

Open

2 tasks

bijington and others added 12 commits September 18, 2024 20:51

Tweak versions in the pipeline

e8e4c21

allow prerelease builds

0223b47

Find overlapping versions for AnxroidX libraries

24f1026

Fix null reference type issue

616ca9c

Shift to TypedBindings

590d8df

Keep disabling IL2092 for NET9_0

39df165

Mark types as Dynamically accessed

39de8a0

Merge branch 'main' into feature/sl-dotnet-nine

51dc62d

Patch up Analyzer unit tests

9514390

Fix the AvatarView unit tests

5677465

Suppress warning disable IL2026

0e90207

Update comments in Camera project

0674abf

brminnick reviewed Sep 19, 2024

View reviewed changes

src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharpAnalyzerVerifier`1+Test.cs Outdated Show resolved Hide resolved

src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharpCodeFixVerifier`2+Test.cs Outdated Show resolved Hide resolved

bijington and others added 2 commits September 19, 2024 20:23

Update src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharp…

446ed60

…AnalyzerVerifier`1+Test.cs Co-authored-by: Brandon Minnick <[email protected]>

Update src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharp…

7e02482

…CodeFixVerifier`2+Test.cs Co-authored-by: Brandon Minnick <[email protected]>

bijington commented Sep 19, 2024

View reviewed changes

src/CommunityToolkit.Maui/Behaviors/EventToCommandBehavior.shared.cs Outdated Show resolved Hide resolved

bijington commented Sep 19, 2024

View reviewed changes

src/CommunityToolkit.Maui/Behaviors/ICommunityToolkitBehavior.shared.cs Outdated Show resolved Hide resolved

bijington commented Sep 19, 2024

View reviewed changes

src/CommunityToolkit.Maui/Behaviors/Validators/ValidationBehavior.shared.cs Outdated Show resolved Hide resolved

bijington and others added 5 commits September 19, 2024 20:28

Include preview builds for benchmarks

8f1ab91

Merge branch 'feature/sl-dotnet-nine' of github.com:CommunityToolkit/…

18e5892

…Maui into feature/sl-dotnet-nine

Remove Obsolete code

d430867

Remove pragma now that unsafe code has been removed

bb378bd

Update ICommunityToolkitBehavior.shared.cs

92213aa

bijington commented Sep 19, 2024

View reviewed changes

src/CommunityToolkit.Maui/Behaviors/ICommunityToolkitBehavior.shared.cs Outdated Show resolved Hide resolved

brminnick reviewed Sep 19, 2024

View reviewed changes

src/CommunityToolkit.Maui/Converters/ICommunityToolkitValueConverter.shared.cs Outdated Show resolved Hide resolved

Update Expander.shared.cs

dce03ba

brminnick added 3 commits December 4, 2024 10:04

Add removed rules

ab225ae

Bump Windows-specific NuGet Packages

7b3181b

Add FluentAssertions.Analyzers

8134fa7

brminnick added 2 commits December 7, 2024 12:25

Bump TOOLKIT_NET_VERSION to 9.0.101

5780553

Merge branch 'main' into feature/sl-dotnet-nine

315b32c

gabsamples6 mentioned this pull request Dec 9, 2024

[BUG] Net 9 Android - StatusBar Color overriden on modal pages #2370

Open

2 tasks

brminnick added 3 commits December 12, 2024 10:38

Update NuGet Packages

c4e129b

Fix typo

8355bae

Update Directory.Build.props

1401cc9

brminnick removed the blocked label Dec 12, 2024

brminnick approved these changes Dec 12, 2024

View reviewed changes

brminnick added the blocked label Dec 12, 2024

bijington mentioned this pull request Dec 15, 2024

[BUG] System.MissingMethodException No constructor found for CommunityToolkit.Maui.Behaviors.TouchBehavior+AccessibilityListener #2383

Open

2 tasks

brminnick requested a review from Copilot December 15, 2024 16:54

Copilot AI reviewed Dec 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support .NET 9.0 #2215

Support .NET 9.0 #2215

bijington commented Sep 18, 2024 •

edited by brminnick

Loading

hansmbakker commented Sep 18, 2024 •

edited

Loading

brminnick left a comment

bijington commented Sep 19, 2024

bijington commented Dec 4, 2024

MauiUIui commented Dec 5, 2024

bijington commented Dec 5, 2024

MauiUIui commented Dec 5, 2024

brminnick left a comment •

edited

Loading

brminnick commented Dec 12, 2024 •

edited

Loading

pictos commented Dec 14, 2024

espenrl commented Dec 15, 2024 •

edited

Loading

bijington commented Dec 15, 2024

Support .NET 9.0 #2215

Are you sure you want to change the base?

Support .NET 9.0 #2215

Conversation

bijington commented Sep 18, 2024 • edited by brminnick Loading

Description of Change

Linked Issues

PR Checklist

Breaking Changes

hansmbakker commented Sep 18, 2024 • edited Loading

brminnick left a comment

Choose a reason for hiding this comment

bijington commented Sep 19, 2024

bijington commented Dec 4, 2024

MauiUIui commented Dec 5, 2024

bijington commented Dec 5, 2024

MauiUIui commented Dec 5, 2024

brminnick left a comment • edited Loading

Choose a reason for hiding this comment

brminnick commented Dec 12, 2024 • edited Loading

pictos commented Dec 14, 2024

Choose a reason for hiding this comment

espenrl commented Dec 15, 2024 • edited Loading

bijington commented Dec 15, 2024

bijington commented Sep 18, 2024 •

edited by brminnick

Loading

hansmbakker commented Sep 18, 2024 •

edited

Loading

brminnick left a comment •

edited

Loading

brminnick commented Dec 12, 2024 •

edited

Loading

espenrl commented Dec 15, 2024 •

edited

Loading