Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cannot update 1.82.1->1.82.3 #614

Open
sino1641 opened this issue Dec 4, 2024 · 8 comments
Open

[Bug]: cannot update 1.82.1->1.82.3 #614

sino1641 opened this issue Dec 4, 2024 · 8 comments
Labels
Needs Triaging This issue needs the developer's attention to sort & prioritize.

Comments

@sino1641
Copy link

sino1641 commented Dec 4, 2024

Affected Version

1.82.1

Bug Behavior

cannot update 1.82.1->1.82.3 with error: System.Runtime.InteropServices.COMException

Expected Behavior

Check and update to 1.82.3

Steps to reproduce

App settings -> Check update

Related Issues

No response

Screenshot(s)

No response

Additional Information

Console Log:

[Info]    Getting CDN Content from: GitLab at URL: https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/metadata/v3/preview/stamp.json
[Info]    Loaded existing staging userId: 31703bc4-af34-525b-ad63-59c18c8c6135
[DBG]     Retrieving latest release feed.
[Info]    Downloading release file 'releases.preview.json' from 'https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/velopack/preview/releases.preview.json?arch=x64&os=win&rid=win-x64&id=CollapseLauncher&localVersion=1.82.1'.
[Info]    Getting CDN Content from: GitLab at URL: https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/velopack/preview/releases.preview.json?arch=x64&os=win&rid=win-x64&id=CollapseLauncher&localVersion=1.82.1
[Info]    Loaded existing staging userId: 31703bc4-af34-525b-ad63-59c18c8c6135
[DBG]     Retrieving latest release feed.
[Info]    Downloading release file 'releases.preview.json' from 'https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/velopack/preview/releases.preview.json?arch=x64&os=win&rid=win-x64&id=CollapseLauncher&localVersion=1.82.1'.
[Info]    Getting CDN Content from: GitLab at URL: https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/velopack/preview/releases.preview.json?arch=x64&os=win&rid=win-x64&id=CollapseLauncher&localVersion=1.82.1
[Info]    Found newer remote release available (1.82.1 -> 1.82.3).
[DBG]     Found 2 delta release(s) between 1.82.1 and 1.82.3.
[Erro]    [Updater::DoesLatestVersionExist] toCheckVersionInfo.ProductVersion is not valid! 1.82.3
[Info]    Found newer remote release available (1.82.1 -> 1.82.3).
[DBG]     Found 2 delta release(s) between 1.82.1 and 1.82.3.
[Info]    Getting CDN Content from: GitLab at URL: https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/preview/fileindex.json
[Info]    Getting CDN Content from: GitLab at URL: https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/changelog_preview.md
[Info]    Loaded existing staging userId: 31703bc4-af34-525b-ad63-59c18c8c6135
[DBG]     Retrieving latest release feed.
[Info]    Downloading release file 'releases.preview.json' from 'https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/velopack/preview/releases.preview.json?arch=x64&os=win&rid=win-x64&id=CollapseLauncher&localVersion=1.82.1'.
[Info]    Getting CDN Content from: GitLab at URL: https://gitlab.com/bagusnl/CollapseLauncher-ReleaseRepo/-/raw/main/velopack/preview/releases.preview.json?arch=x64&os=win&rid=win-x64&id=CollapseLauncher&localVersion=1.82.1
[Erro]    [MyImage::LoadImage()] Failed while loading image from https://github.com/user-attachments/assets/4f3ed7d6-19a0-4aad-8573-6cf23339e49d
System.Runtime.InteropServices.COMException (0x88982F50)
   at CommunityToolkit.Labs.WinUI.Labs.MarkdownTextBlock.TextElements.MyImage.LoadImage(Object sender, RoutedEventArgs e)
@sino1641 sino1641 added the Needs Triaging This issue needs the developer's attention to sort & prioritize. label Dec 4, 2024
@bagusnl
Copy link
Member

bagusnl commented Dec 4, 2024

Seems like a NRE on the LoadImage causing catastrophic crash, I'll see what I can do but for now, please reinstall your current Collapse installation with the new exe in Releases

@Mylloon
Copy link

Mylloon commented Dec 4, 2024

FYI, forcing the update in the settings works

@sino1641
Copy link
Author

sino1641 commented Dec 4, 2024

Hi,
Surely yes download from Github Releases always fixes the issue.
But it could be better if there is a catch/fix for it and for good.

@bagusnl
Copy link
Member

bagusnl commented Dec 5, 2024

Thanks for filling up the issue, we are fully aware that many people were not able to update their instance of Collapse. This was due to some bad code when migrating from Squirrel to Velopack update mechanism.

For anyone who has something like this in the Console or when pressing "Check for Updates" regardless of version
"Cannot perform this operation in an application which is not installed."
please reinstall your instance using the new installer found in 1.82.3 release page https://github.com/CollapseLauncher/Collapse/releases/tag/CL-v1.82.3-pre

Our plan to remedy this issue is by having our legacy updater method (ApplyUpdate) to always take over in any case where Velopack fails (currently it only take over when the update process itself fails, but not when the checking fails). But as I was trying to do this last night, it seems that the code is quite convoluted which will make this take a bit more time than I was expecting.

Users has been notified using our notification system by this commit CollapseLauncher/CollapseLauncher-ReleaseRepo@1a7cf10

Copy link

sentry-io bot commented Dec 5, 2024

Sentry Issue: COLLAPSE-LAUNCHER-1N

Copy link

sentry-io bot commented Dec 5, 2024

Sentry Issue: COLLAPSE-LAUNCHER-6D

Copy link

sentry-io bot commented Dec 5, 2024

Sentry Issue: COLLAPSE-LAUNCHER-2H

Copy link

sentry-io bot commented Dec 5, 2024

Sentry Issue: COLLAPSE-LAUNCHER-53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triaging This issue needs the developer's attention to sort & prioritize.
Projects
None yet
Development

No branches or pull requests

3 participants