Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: provide PREFER_EXTERNAL_XXHASH configuration option #489

Open
keszybz opened this issue May 14, 2023 · 2 comments
Open

RFE: provide PREFER_EXTERNAL_XXHASH configuration option #489

keszybz opened this issue May 14, 2023 · 2 comments

Comments

@keszybz
Copy link
Contributor

keszybz commented May 14, 2023

In compilation for Fedora, I'm able to set -DPREFER_EXTERNAL_LZ4:BOOL=ON, -DPREFER_EXTERNAL_ZLIB:BOOL=ON, -DPREFER_EXTERNAL_ZSTD:BOOL=ON, but I see a bundled copy of xxhash is still being used. It'd be great to use the distro copy too.

@keszybz
Copy link
Contributor Author

keszybz commented May 14, 2023

With the following:

rm -v plugins/codecs/ndlz/xxhash.?
sed -r -i '/xxhash.c/d' plugins/codecs/ndlz/CMakeLists.txt

everything builds fine and test_plugin_test_ndlz passes without issue.

So it seems that it'd be just a matter of skipping the xxhash.c from the sources and ensuring that xxhash.h from /usr/include is used.

@FrancescAlted
Copy link
Member

Ok, but this will add the xxhash dependency, right? I suppose we would need something like PREFER_EXTERNAL_XXHASH. If you can provide a PR, I'll be happy to discuss more about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants