Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: v2rayN autoupdate replaces regional geoip/geosite files with the default ones #6218

Open
2 tasks done
eliotcougar opened this issue Dec 4, 2024 · 3 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@eliotcougar
Copy link

预期情况

When the regional Russian setting is enabled, and some of the regional tags are used in the routing rules, when you update v2rayN with a new version, the updater unpacks geoip/geosite files from the downloaded archive and replaces the regional files. These default files don't have the regional tags in them. As the result, the app doesn't work after the restart because xray-core reports missing tags in routing settings.

实际情况

Autoupdater should not overwrite regional geoip/geosite files with the default "Chinese" files from the distribution.

复现方法

Use regional Russian settings;
Set up some routing rules that use geosite:ru-blocked-all and geoip:ru-blocked rules;
Autoupdate v2rayN to a new version.
After a restart, xray-core fails to start.

日志信息

2024/12/04 14:32:58 [Info] infra/conf/serial: Reading config: &{Name:config.json Format:json}
Failed to start: main: failed to load config files: [config.json] > infra/conf: invalid field rule > infra/conf: failed to parse domain rule: geosite:ru-blocked-alll > infra/conf: failed to load geosite: RU-BLOCKED-ALL > infra/conf: list not found in geosite.dat: RU-BLOCKED-ALL

额外信息

XTLS/Xray-core#4105

我确认已更新至最新版本

我确认已查询历史issues

@eliotcougar eliotcougar added the bug Something isn't working label Dec 4, 2024
@2dust
Copy link
Owner

2dust commented Dec 4, 2024

Even if you can't write code, you can consider that the next GUI program cannot achieve the functions you want
If the core cannot be implemented, then the GUI program cannot solve this problem.

@eliotcougar
Copy link
Author

eliotcougar commented Dec 4, 2024

I have a strong feeling there is some miscommunication (language barrier) here. I don't understand what you try to say in the comment above.
You've implemented a new feature - regional geoip/geosite files. However, another feature (autoupdater) breaks that new feature. Something has to be adjusted in the autoupdate logic to prevent this.

@2dust
Copy link
Owner

2dust commented Dec 5, 2024

This application is only for users in mainland China and has not been tested in other regions. If anyone can solve this problem, please PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants