Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one composer.json file #255

Open
tobeycodes opened this issue Nov 25, 2024 · 0 comments
Open

Use one composer.json file #255

tobeycodes opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tobeycodes
Copy link
Member

Currently the scaffold ships with 3 composer.json plugins. Some of the reasons why I think this makes sense to use one composer.json

  • We are not shipping the theme and plugin to a package repository like packagist.org
  • We are loading the same dependencies in multiple composer.json files (vendor bloat)
  • We are not truly isolating the theme and plugin. For example we load phpcs at the root, but if we have separate packages each should be responsible for it's own linting
  • This will simplify local setup for engineers
  • This will reduce build and deploy times in CI
  • We can either use move autoloading to a Autoloader class (<20 LOC) or put them at the root composer.json (which forces lazy initialization and good sign of code quality)
@tobeycodes tobeycodes added the enhancement New feature or request label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant